16:57:28
rbrunner7:monero.social:
Meeting in 1 hour
17:59:21
rbrunner7:monero.social:
Meeting time. Hello! https://github.com/monero-project/meta/issues/1322
17:59:44
jeffro256:monero.social:
Howdy
18:00:12
jberman:monero.social:
*waves*
18:00:56
sneedlewoods_xmr:matrix.org:
Hello
18:01:26
rbrunner7:monero.social:
Alright, let's start with the reports from last week
18:01:36
vtnerd:monero.social:
Hi
18:02:03
sneedlewoods_xmr:matrix.org:
mainly worked on vtnerds review comments [here](https://github.com/monero-project/monero/pull/10232#pullrequestreview-3623648856)
18:02:09
sneedlewoods_xmr:matrix.org:
also updated #9464 and left a comment https://github.com/monero-project/monero/pull/9464#issuecomment-3724414260
18:02:19
vtnerd:monero.social:
Me: no tangible updates on lws/lwsf, working on something unrelated
18:02:23
sneedlewoods_xmr:matrix.org:
and created a new branch for "replace wallet2 with Wallet API in `monero-wallet-rpc`" (but not much happened on it)
18:02:56
rbrunner7:monero.social:
That work just got financed, right? Nice.
18:03:58
sneedlewoods_xmr:matrix.org:
Yes, huge thanks to all supporters and donors
18:04:43
jberman:monero.social:
me: we released v1.5 of the alpha stressnet (seems to be holding up reasonably well), completed a solution for the xmrig segfault (upstream PR incoming), 0xfffc merged my tx relay v2 changes into his branch (thank you!), we may be in solid shape for beta soon
18:06:31
rbrunner7:monero.social:
Any news about any ongoing Carrot related reviews, jeffro256 ?
18:07:43
jeffro256:monero.social:
Me: I'm working on implementing the scaling changes for beta stressnet
18:08:29
jeffro256:monero.social:
On of the firms reached out to maybe perform a partial or full audit of carrot_core, which would be awesome. I won't mention it more until they commit
18:08:47
rbrunner7:monero.social:
Changes designed to trigger effects earlier, as discussed recently? Different from the "real" Mainnet scaling parameters
18:11:13
rbrunner7:monero.social:
Anyway. I have something that may make sense to discuss in this round, maybe enough "brains" currently present to make sense
18:12:09
rbrunner7:monero.social:
Recently I glanced over vtnerd 's review of the expanded Wallet API, as an API, where some mention of `monero_c` got me thinking
18:12:14
jberman:monero.social:
( believe the latter, the "real" mainnet scaling params)
18:12:35
rbrunner7:monero.social:
If I am not mistaken, it's about this one: https://github.com/MrCyjaneK/monero_c
18:13:15
rbrunner7:monero.social:
I think it was some question about compatibility of the new Wallet API release with a "C only" wrapper, regarding callbacks?
18:13:40
jeffro256:monero.social:
For free btw
18:14:18
rbrunner7:monero.social:
Which leads me to the question: Is it our responsibility, while modifying and expanding the Wallet API, to make such C based wrappers not unnecessarily hard and complicated, or is this out of scope, so to say?
18:14:29
sneedlewoods_xmr:matrix.org:
the comment for reference https://github.com/monero-project/monero/pull/10232#discussion_r2658678511
18:15:12
rbrunner7:monero.social:
Thanks, sneedlewoods, exactly that :)
18:15:31
rbrunner7:monero.social:
But there may be other possible pain points
18:16:41
sneedlewoods_xmr:matrix.org:
I don't know much about monero_c, but AFAIK it's important enough that we should not break it
18:16:53
vtnerd:monero.social:
Yes the monero_c code doesn't support listeners as it's a bit messy to support. So the password change for listeners hopefully won't be required for API users or monero _c has a bunch of work (and so does dart bindings et al)
18:17:09
rbrunner7:monero.social:
I was mistaken, I first thought it is still based directly on wallet2 ...
18:17:13
vtnerd:monero.social:
Monero_c is used by cake afaik
18:17:17
jberman:monero.social:
+1 to keeping the C wrapper in mind
18:17:32
jberman:monero.social:
and therefore +1 to avoid required callbacks
18:17:38
vtnerd:monero.social:
Skylight definitely is too
18:18:07
rbrunner7:monero.social:
Ah, so you can get everything running with ignoring callbacks entirely?
18:18:14
sneedlewoods_xmr:matrix.org:
That's all related to `unattended` setting, iamamyth also left a comment I need to dig into https://github.com/monero-project/monero/pull/10232#discussion_r2674328535
18:18:34
rbrunner7:monero.social:
Was wondering about that "unattended"
18:19:10
vtnerd:monero.social:
Currently, yes. But needed SNeedlewoods @sneedlewoods_xmr:matrix.org: to respond about newer changes as I haven't gone through the implementation, primarily just went through the API which is still pretty lengthy
18:19:40
vtnerd:monero.social:
Currently yes -> listeners are not required
18:20:42
sneedlewoods_xmr:matrix.org:
AFAICT they're still not required if you keep `unattended = true` as it was the default before, but have to double check
18:21:16
vtnerd:monero.social:
Ah ok, will have to go back through and verify all of this then
18:22:40
rbrunner7:monero.social:
By the way, is the author "MrCyjaneK" active around here, in the Matrix rooms and/or on IRC? Maybe it would be good for them to have a look what we are up to here ...
18:23:12
rbrunner7:monero.social:
Easier to correct / adjust things now than later
18:23:16
vtnerd:monero.social:
I would tag them on GitHub, they've commented on something I've done before
18:24:16
rbrunner7:monero.social:
Maybe even ready to help reviewing, who knows
18:25:04
rbrunner7:monero.social:
So things are probably safe. Good to hear.
18:25:44
rbrunner7:monero.social:
Anything else to discuss today?
18:26:39
sneedlewoods_xmr:matrix.org:
Not from me, will post updates on the PRs or in here during the week when I figured things out+
18:27:30
rbrunner7:monero.social:
Well then. Thanks everybody for attending, read you again next week!
18:28:02
jberman:monero.social:
thanks!
18:30:29
sneedlewoods_xmr:matrix.org:
thanks everyone, see ya