05:38:13 Guest93: Hi
18:48:37 DataHoarder: can't compile release-v0.18 on latest fedora 43, command_line.h:187:8: error: definition with same mangled name '_ZN12command_line7add_argIbLb0ELb0ELi1EEEvRN5boost15program_options19options_descriptionERKNS_14arg_descriptorIT_XT0_EXT1_EXT2_EEEb' as another definition
18:51:27 DataHoarder: (somehow seraphis fork does work?)
18:54:04 o​frnxmr:xmr.mx: Fcmp fork is of master
18:56:31 DataHoarder: yeah, but this is old code (last touched 2018)
18:56:45 v​tnerd:monero.social: I got this with clang-21 the other day. The fix isn't too bad, I'll issue a pr
18:56:59 DataHoarder: untouched in fcmp
18:57:30 DataHoarder: got a patch meanwhile for it?
18:58:34 v​tnerd:monero.social: Yeah just remove the `template<>` line and make the third parameter optional by defaulting to false
18:58:48 v​tnerd:monero.social: Hold on
18:59:29 v​tnerd:monero.social: Or make it true sorry
19:00:27 v​tnerd:monero.social: ```
19:00:33 v​tnerd:monero.social: ```
19:00:34 v​tnerd:monero.social: diff --git a/src/common/command_line.h b/src/common/command_line.h
19:00:36 v​tnerd:monero.social: index 681eb903b..a8a718012 100644
19:00:38 v​tnerd:monero.social: --- a/src/common/command_line.h
19:00:40 v​tnerd:monero.social: +++ b/src/common/command_line.h
19:00:42 v​tnerd:monero.social: @@ -207,8 +207,7 @@ namespace command_line
19:00:44 v​tnerd:monero.social: description.add_options()(arg.name, make_semantic(arg, def), arg.description);
19:00:46 v​tnerd:monero.social: }
19:00:48 v​tnerd:monero.social:
19:01:54 d​atahoarder:monero.social: ^
19:01:56 d​atahoarder:monero.social: ```
19:01:58 d​atahoarder:monero.social: monero/src/common/command_line.h:211:126: error: redefinition of default argument
19:02:00 d​atahoarder:monero.social: 211 | inline void add_arg(boost::program_options::options_description& description, const arg_descriptor<bool, false>& arg, bool unique = true)
19:02:02 d​atahoarder:monero.social: | ^ ~~~~
19:02:04 d​atahoarder:monero.social: monero/src/common/command_line.h:187:140: note: previous definition is here
19:02:06 d​atahoarder:monero.social: 187 | void add_arg(boost::program_options::options_description& description, const arg_descriptor<T, required, dependent, NUM_DEPS>& arg, bool unique = true)
19:02:08 d​atahoarder:monero.social: ```
19:02:25 v​tnerd:monero.social: lol so much for an easy fix. what compiler is this?
19:03:15 d​atahoarder:monero.social: clang 21.1.8
19:04:39 v​tnerd:monero.social: let me double check what I did previously, this was from memory
19:14:36 v​tnerd:monero.social: I dont know, this works with clang 21.1.8 on gentoo
19:22:27 v​tnerd:monero.social: was the `template<>` removed? I get that error if that line is not removed
20:42:40 d​atahoarder:monero.social: right, I didn't remove it