15:00:24 selsta: .merge+ 10318 10319
15:00:24 xmr-pr: Added
17:31:46 selsta: any opinion on PRs like this? https://github.com/monero-project/monero/pull/10326 clearly AI generated but would add test cases
17:32:08 selsta: seems to be quite low level tests of things that are unlikely to break
17:46:25 sech1: Okay, I approved another PR because it was a single line change. But this... They need to pay us to review this...
17:50:13 sech1: As for tests: don't accept new test just for the sake of tests. New tests should be added together with an entirely new code, or together with bugfixes - i.e. a test that makes the old code fail + the code fix
17:53:21 sech1: and yes, it's a PR from the same "team": https://gittensor.io/miners/repository?name=monero-project%2Fmonero (click on "Pull Requests" tab)
17:55:38 selsta: ok i will close it, also it did not even disclose the fact it's AI
18:27:45 r​brunner7:monero.social: Cool, that 'combinations_count' method really needs some tests. With priority :)
18:28:35 r​brunner7:monero.social: That "gittensor" thing at a quick glance looks like some sort of contest?
18:29:10 r​brunner7:monero.social: "Who can get the most PRs merged into the highest-ranking projects"
22:21:09 tobtoht: .merges
22:21:09 xmr-pr: 10299 10312 10314 10315 10316 10317 10318 10319
22:21:19 tobtoht: done
22:30:05 selsta: thanks! is there anything missing for https://github.com/monero-project/monero/issues/10308 ?
22:30:24 selsta: otherwise I'll ask for a tag in the next days