12:38:10 c​ryptagupta:matrix.org: Thank you. I will submit the PR shortly.
12:38:12 c​ryptagupta:matrix.org: While running the CI, I'm coming across an "unused import 'pin'" in multiple places. this is a pre-existing condition, not related to my changes. i'm wondering if I should clean it up as part of the PR? it seems too small to open a separate issue for.
12:38:44 c​ryptagupta:matrix.org: Thank you. I will submit the PR shortly.
12:38:46 c​ryptagupta:matrix.org: While running the CI, I'm coming across an "unused import 'pin'" in multiple places. this is a pre-existing condition, not related to my changes. i'm wondering if I should clean it up as part of the PR? it seems too small to open a separate issue for.
13:24:22 b​oog900:monero.social: Hmm yeah that shouldn't be happening yeah you can fix it in your PR
13:47:43 c​ryptagupta:matrix.org: will do. there's also an unused assignment to an array element, that looks like it may be orphaned code as well.
14:01:39 b​oog900:monero.social: Yeah you may need to feature flag things like that out
14:05:20 c​ryptagupta:matrix.org: ah. you mean delete them? why feature flag them out?
14:09:24 b​oog900:monero.social: Because if the assignment isn't used then it isn't needed
14:09:48 b​oog900:monero.social: Unless the way the value for the assignment is got has side effects
14:10:02 c​ryptagupta:matrix.org: yes, but shouldn't the assignment just be deleted?
14:11:07 c​ryptagupta:matrix.org: that would be a code smell, no? i'm not super familiar with rust, but that sounds odd.
14:11:47 b​oog900:monero.social: Oh I thought it would be needed for arti
14:12:49 c​ryptagupta:matrix.org: i think it was in cryptonight
14:14:18 b​oog900:monero.social: Ah yeah just remove it then
17:07:15 c​ryptagupta:matrix.org: I submitted the PR
17:07:16 c​ryptagupta:matrix.org: https://github.com/Cuprate/cuprate/pull/575
17:13:32 b​oog900:monero.social: did you use AI?
17:17:03 g​ingeropolous:monero.social: boog900: , yeah monerosim uses RPC on the monerod and wallet
17:17:14 c​yrix126:gupax.io: I don't know what your stands are on macros, but a lot of repetitive `#[cfg(feature = "arti")]` lines could be reduced with https://docs.rs/cfg-if
17:18:52 b​oog900:monero.social: ah RPC isn't ready yet, lots of people are waiting on it :)
17:19:04 g​ingeropolous:monero.social: gotcha
17:22:07 b​oog900:monero.social: I would rather just repeat this than pull in that crate ngl, although we do already pull that in IIRC, I would rather not directly depend on it.
17:22:08 b​oog900:monero.social: I do plan to, at some stage, properly go through all our dependencies to try reduce them.
21:24:42 h​into:monero.social: fyi 574 is open and fixes CI issues
21:30:12 h​into:monero.social: IIRC rust libs themselves pull in `cfg-if` among others
21:34:34 h​into:monero.social: I'd think crates maintained under Rust proper are in a different category in the context of reducing deps e.g. cfg-if regex libc hashbrown etc