06:45:23
jeffro256:
If this is planned to be a stable feature, can we have a C endpoint exposed for it, please? > <sech1> Don't even need to create a new vm, see "test_switch" in src/tests.cpp
08:24:57
DataHoarder:
something along the lines of RANDOMX_EXPORT void randomx_vm_set_flags(randomx_vm *machine, randomx_flags flags);?
08:25:06
DataHoarder:
as it has set_cache and set_dataset already
08:25:17
DataHoarder:
and otherwise it's init as RANDOMX_EXPORT randomx_vm *randomx_create_vm(randomx_flags flags, randomx_cache *cache, randomx_dataset *dataset);
08:38:03
sech1:
No, `randomx_vm_set_flags` won't work on the already created vm
08:38:20
sech1:
Only v2 flag was implemented to be dynamic
08:39:20
sech1:
Why C API for this? setFlagV2/clearFlagV2 are available in randomx_vm class, it should be enough for monerod
08:44:32
sech1:
Adding an API for a one-time event seems an overkill
08:50:34
DataHoarder:
yeah, which is why just calling randomx_create_vm effectively just does this tbh
08:50:50
DataHoarder:
it's 2 MiB+ a bit of state if you want to keep two at the same time
08:51:16
DataHoarder:
If they want to use the C++ stuff then they have access to more