14:48:46
hyc:
@sech1 I just had a couple nits on the v2 PR. you can do something or just close them, then I'll approve
14:49:19
hyc:
tests are fine here on amd64 and riscv64. need to dust off my arm64 linux box still
14:53:50
hyc:
all good on my rk3399
14:57:17
sech1:
Yes, I saw the notifications. I'll go through them today. Re 25 commits - they will he squashed of course
14:57:44
sech1:
Before the final merge
20:46:37
tevador:
sech1: Have you tested the v2 code with UBSan?
20:49:38
sech1:
Hmmm. I have v2 code in p2pool already, and it runs an ubsan test. But not specifically v2.
20:50:19
sech1:
I guess I need to compile with ubsan on arm64 and risc-v and test
21:29:28
sech1:
ARM64 test: https://pastebin.com/DUuirQxu
21:29:41
sech1:
I'll fix ARM64 code anyway because of possible alignment issues
21:30:10
sech1:
But RISC-V code shouldn't have alignment issues, so I'll just test it for UB
21:30:23
sech1:
But Debug build with UB sanitizer is sloooow, it'll take some time
21:39:48
sech1:
Okay, risc-v test spitted a lot of "misaligned access" errors in unrelated places, I'll take a look
22:06:09
tevador:
Yeah, misaligned access can just crash on some RISC-V machines.
22:07:57
sech1:
I only see it complaining about 64-byte alignment because we have alignas(64) in virtual_machine.hpp
22:08:14
sech1:
Technically it's just a performance optimization there, and can be ignored
22:13:55
sech1:
RISC-V test: https://pastebin.com/PFrzAaPt
22:14:15
sech1:
some bit shift UB, but it's not UB on RISC-V because RISC-V is defined as two's complement
22:14:29
sech1:
and a lot of 64-byte alignment warnings, they can be ignored
22:16:14
sech1:
ah no, found one: /root/RandomX/src/jit_compiler_rv64_vector.cpp:368:16: runtime error: store to misaligned address 0x7fffa75ff0ba for type 'uint32_t', which requires 4 byte alignment
22:16:42
sech1:
one 4-byte and 370 64-byte alignment messages
22:34:24
sech1:
Updated RISC-V test: https://pastebin.com/NfWM67EK
22:34:52
sech1:
ah, I see it's already approved
22:35:11
sech1:
hyc I'll wait a couple more days for you to review, and then push "squash-and-merge" button
22:58:18
tevador:
The next step is monerod integration.