11:08:04 b​asses:matrix.org: does monero require contributers to sign their commits?
11:11:55 o​frnxmr:xmr.mx: No
11:15:20 b​asses:matrix.org: why
11:16:23 o​frnxmr:xmr.mx: Why would it
11:17:05 o​frnxmr:xmr.mx: We merge code from anyone, not just paranoid ppl
11:24:07 o​frnxmr:xmr.mx: and nobody is allowed to push directly to the repo. Gpg signing is a nice to have, but really only makes a difference for repos that have people commiting directly to them
11:24:49 g​gdev:mdev.nutra.tk: it's not hard to make a key. No harder or crazier than washing hands before meals.
11:24:50 g​gdev:mdev.nutra.tk: Can you guys offer suggestions/feedback on PRs to feather or cake?
11:25:05 b​asses:matrix.org: only core do push, right?
11:25:34 b​asses:matrix.org: and they sign their commits?
11:47:53 o​frnxmr:xmr.mx: They dont
11:48:06 o​frnxmr:xmr.mx: [#monero-community-dev:monero.social](https://matrix.to/#/%23monero-community-dev:monero.social)
11:48:23 b​asses:matrix.org: bruh, they should
11:48:35 o​frnxmr:xmr.mx: they dont push to the repo*
11:48:47 b​asses:matrix.org: oh ok.
11:48:53 o​frnxmr:xmr.mx: They go thru prs as well
11:50:43 o​frnxmr:xmr.mx: You could say that its preferred that people sign their commits, but _nobody_ is checking, and we dont even require you to use git. You can send code via a pastebin
11:50:45 b​asses:matrix.org: I actually checked pushes https://github.com/monero-project/monero/commits/master/ known developers sign their commits, except some other community contributors
11:51:13 b​asses:matrix.org: https://matrix.monero.social/_matrix/media/v1/download/matrix.org/uhlluuoGlmnWthnxpIxNZZKq
11:51:17 o​frnxmr:xmr.mx: Navid and vtnerd are known devs
11:51:30 b​asses:matrix.org: shows "Verified" if they sign commits
11:51:50 o​frnxmr:xmr.mx: https://matrix.monero.social/_matrix/media/v1/download/xmr.mx/VQyqcDgXIAvwaRusIustdGNO
11:52:05 b​asses:matrix.org: would be good if they sign their commits then
11:52:20 b​asses:matrix.org: click on 3 dots
11:52:22 o​frnxmr:xmr.mx: Yeah, some sign (tob), some sign sometomes (jeffro), some dont sign ( a bunch more)
11:52:50 o​frnxmr:xmr.mx: ? Its not signed
11:53:12 b​asses:matrix.org: yeah, indeed, weird as his latest commits are signed
11:53:27 g​gdev:mdev.nutra.tk: i'm sure impersonating someone is fairly rare, and in serious cases, might be punishable
11:53:28 o​frnxmr:xmr.mx: https://matrix.monero.social/_matrix/media/v1/download/xmr.mx/juANMhWaQmEXMdQEkdcRKvsv
11:53:30 b​asses:matrix.org: actually majority of his commits
11:53:44 g​gdev:mdev.nutra.tk: in any case the devs all sign a deterministic guix build at least for feather
11:53:54 o​frnxmr:xmr.mx: Nobody cares - the prs are reviewed
11:54:11 g​gdev:mdev.nutra.tk: ya its just a formality or extra security measure for nerds ig
11:54:21 o​frnxmr:xmr.mx: We sign deterministic gitian builds for monero
11:54:29 sech1: can you move this conversation to another channel
11:54:32 b​asses:matrix.org: not rare, and you can't punish if you are not enforcing commit signing
11:54:56 sech1: #monero
11:56:41 g​gdev:mdev.nutra.tk: anyway my request not tonight another time, but i have a tricky PR in the works for feather/cake that's almost a hybrid between offline and continuous sync
11:57:21 g​gdev:mdev.nutra.tk: which after i started working on it, started feeling so wrong, like paddling up river. But it's a convenience factor, too
11:57:41 o​frnxmr:xmr.mx: [#monero-community-dev:monero.social](https://matrix.to/#/%23monero-community-dev:monero.social) [@ggdev:mdev.nutra.tk](https://matrix.to/#/@ggdev:mdev.nutra.tk)
16:22:12 s​weetkanoe:matrix.org: why is every stagenet xmr faucets down bru
16:22:23 s​weetkanoe:matrix.org: even the stagenet explorer is down
16:45:39 s​weetkanoe:matrix.org: @plowsof - Hey, just wanted to ping you here since I saw you're in this group. I posted my completed RoboSats-XMR fork on the bounty page a few hours ago (2.009 XMR bounty). 12/12 tests passing, code's on GitHub, everything's done except I need a tiny bit of stagenet XMR to finish end-to-end testing. Could you take a look when you have a moment? Thanks!
16:46:28 s​weetkanoe:matrix.org: plowsof - Hey, just wanted to ping you here since I saw you're in this group. I posted my completed RoboSats-XMR fork on the bounty page a few hours ago (2.009 XMR bounty). 12/12 tests passing, code's on GitHub, everything's done except I need a tiny bit of stagenet XMR to finish end-to-end testing. Could you take a look when you have a moment? Thanks!
17:45:11 r​brunner7:monero.social: sweetkanoe: Please drop your stagenet address here, I will send something
18:06:35 s​weetkanoe:matrix.org: 57AMFjwXiSS39p4WU7zFNKZ3RKopHjnta1sTP75FhHK5GrJ2uGu3LELSEF3F6LirwNXyuQxuw6uGABQH9No1UsurE6136ko
18:06:35 s​weetkanoe:matrix.org: thanks :)
18:09:44 j​babb:cypherstack.com: 926830119ed33ddc2d00c3a11d0759beae5895ad09fc5cb8050a6b285b30ffdf
18:14:42 o​frnxmr:xmr.mx: Monero Bounties
18:20:39 s​weetkanoe:matrix.org: idk why but i havent received it like fr, i also tried a faucet but it also showed sent but i didnt recieve that either
18:21:09 j​babb:cypherstack.com: 7 confirmations, idk
18:21:29 j​babb:cypherstack.com: some sync issue
18:21:59 s​weetkanoe:matrix.org: ah prob yeah, i will wait i guess
18:22:17 o​frnxmr:xmr.mx: Are you connected to a node..?
18:22:19 j​babb:cypherstack.com: what's your stagenet height? it's in block 2067633, you should have it...
18:23:37 s​weetkanoe:matrix.org: yep that was the error
18:23:51 s​weetkanoe:matrix.org: no daemon connected
18:23:58 s​weetkanoe:matrix.org: am dumb
18:31:50 j​babb:cypherstack.com: I mined you some coinbases that will have a locktime 60, hope your code handles edge cases >:D
18:33:19 s​weetkanoe:matrix.org: lol
18:34:14 jpk68: sweetkanoe: How did you test it on stagenet/testnet before submitting to the bounty?
18:34:52 jpk68: Since you didn't have stagenet coins
18:35:51 s​weetkanoe:matrix.org: i tested it on stagenet by running monero-wallet-rpc in stagenet mode and connecting to public nodes. faucets were all down so i asked around in the monero matrix rooms and someone sent me a bit of stagenet xmr to work with. the robosats fork uses that rpc for everything — generating subaddresses, handling 10-block locks, checking balances, sending between wallets. all 12 tests <clipped message>
18:35:51 s​weetkanoe:matrix.org: pass. just waiting for the wallet to sync so i can finally run an actual trade from end to end.
18:35:55 s​weetkanoe:matrix.org: am sure i got enough time before he tests the code
18:37:17 o​frnxmr:xmr.mx: Were way off topic
18:37:30 o​frnxmr:xmr.mx: Nove to bounties room plz, or Monero Community Dev
18:38:23 s​weetkanoe:matrix.org: sorry for that, again.
18:47:42 s​weetkanoe:matrix.org: got the xmr, thanks dude u saved me big time
18:48:15 j​babb:cypherstack.com: np bruv frfrf