16:26:59
kayabanerve:matrix.org:
binarybaron: Do you want to PR derive(Hash)? 😅
16:28:12
kayabanerve:matrix.org:
Huh. That doesn't immediately work. Address has Point which doesn't impl Hash.
16:28:25
kayabanerve:matrix.org:
... why does Address use Point instead of CompressedPoint 🤔🤔🤔
16:29:05
kayabanerve:matrix.org:
ACK on the feature request and that this isn't in fact a one-line change. I support it, with the caveat I support it if it's cheap (point compressions aren't) therefore causing larger changes to be necessary.
16:31:25
kayabanerve:matrix.org:
boog900 @boog900:monero.social: Should address equality be equivalent over the encoding or the semantics?
16:31:49
kayabanerve:matrix.org:
Featured allows re-encoding identical semantics
16:31:58
kayabanerve:matrix.org:
cc binarybaron: for an opinion
16:33:23
kayabanerve:matrix.org:
... does this imply addresses shouldn't implement equality, instead only implementing encoding_eq and semantic_eq?
16:33:43
kayabanerve:matrix.org:
That'd prevent usage in a hashmap though
16:35:12
kayabanerve:matrix.org:
Since `network` is encoding alone, and people presumably don't want addresses for distinct networks considered equivalent, I'd say that line of logic discounts a semantic eq regarding if featured or not?
16:35:38
kayabanerve:matrix.org:
But it's probably worth a doc comment that equality is over the encoded values, not the semantics.
16:35:56
kayabanerve:matrix.org:
Then yes, Hash is straightforward once the decompressed points are removed from address.